[PATCH] - enhanced the HSSFCellStyle constants list

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] - enhanced the HSSFCellStyle constants list

Andreas Engel
Hello out there,

i'm not sure this hits the right place. if thats the case please give an
advice where to post instead.

while using the poi library for some time now i had to play around with excel
cell styles, mainly the bgcolor attributes. so i realized that there are two
constants missing: the lesser and least dotted styles. i added them to class
HSSFCellStyle. someone should check the wording of the constant names.

please take this as a kind of test for further commitments to this project.
any advice to meet common commitment rules is appreciated.

and last but not least ... the patch file:

thanks for your outstanding work
andreas engel, germany
mail AT a-engel.de

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

styleenhancement.patch (931 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] - enhanced the HSSFCellStyle constants list

Avik Sengupta
Committed, thanks.

In the future, could you please attach patches to our bug tracker
http://issues.apache.org/bugzilla/
Things in emails tend to fall thru the cracks.

Also, anything without unit tests is less likely to be evaluated or
committed... our experience shows that code without unit tests tend to
bit-rot fairly quickly.

Regards
-
Avik


On Fri, 2005-05-20 at 22:02 +0200, Andreas Engel wrote:

> Hello out there,
>
> i'm not sure this hits the right place. if thats the case please give an
> advice where to post instead.
>
> while using the poi library for some time now i had to play around with excel
> cell styles, mainly the bgcolor attributes. so i realized that there are two
> constants missing: the lesser and least dotted styles. i added them to class
> HSSFCellStyle. someone should check the wording of the constant names.
>
> please take this as a kind of test for further commitments to this project.
> any advice to meet common commitment rules is appreciated.
>
> and last but not least ... the patch file:
>
> thanks for your outstanding work
> andreas engel, germany
> mail AT a-engel.de
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
--


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/