[GitHub] poi pull request #94: New module RangeCopier.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] poi pull request #94: New module RangeCopier.

asfgit
GitHub user zmau opened a pull request:

    https://github.com/apache/poi/pull/94

    New module RangeCopier.

    RangeCopier does simple copying of regions on workbook.  It comes in two versions - as XSSFRangeCopier and HSSFRangeCopier. It copies regions in same way as Excel does - tiling destination region with source region as pattern. Source and destination regions may be on different sheets.
    It also takes care of formulas in copied cells.
    I have also provided test classes with a few test cases, for both XSSF and HSSF context. Files with test data are also here.
   
    Please take a look at my method RangeCopier.cloneCellContent(). It may be problematic, because I have maybe omitted some Cell attributes which should also be cloned.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zmau/poi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
   
----
commit 7422de37fb4e2db27405c3a8ac75530b46973f18
Author: zmau <drjovanovic@...>
Date:   2017-11-01T13:10:58Z

    Formula adjusting in context of column shifting.

commit d9351b5e381a1ed4b9b73cc774fbd901c9400dd7
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-01T13:36:23Z

    Merge branch 'trunk' into trunk

commit 45066eec434d9d0102466e5230fe18047edf1f1f
Author: zmau <drjovanovic@...>
Date:   2017-11-02T14:05:12Z

    fixed some details
   
    as discussed on https://github.com/apache/poi/pull/81

commit b6c9d9fffd7109fb43f9b075fb81185c8c82ff6f
Author: zmau <drjovanovic@...>
Date:   2017-11-02T14:25:59Z

    Merge remote-tracking branch 'origin/trunk' into trunk

commit 9ad6ed9aca5372986de4a057aeb0a8707cba1969
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-03T12:43:23Z

    Replaced tab characters with spaces
   
    (Other commented issues are not covered in this commit.)

commit f3e0a5001328aa2bb04a909b298ad67edbcfd375
Author: zmau <drjovanovic@...>
Date:   2017-11-06T14:03:22Z

    Merge remote-tracking branch 'origin/trunk' into trunk

commit 09ba25b035911fad8a9d0a4f293f21fb2ef57eca
Author: zmau <drjovanovic@...>
Date:   2017-11-02T14:05:12Z

    fixed some details
   
    as discussed on https://github.com/apache/poi/pull/81
    # Conflicts:
    # src/java/org/apache/poi/ss/formula/FormulaShifter.java

commit 3637c17fd069978a4e76a4f924d6cb923d9eef12
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-08T10:59:11Z

    Merge branch 'trunk' into trunk

commit c71cad8b37763fc0f750c31dbce9aa24b6d563c5
Author: zmau <drjovanovic@...>
Date:   2017-11-08T11:01:15Z

    Merge remote-tracking branch 'origin/trunk' into trunk

commit eddb8acba795bb5562a82d56c8d3bcdb67411243
Author: zmau <drjovanovic@...>
Date:   2017-11-10T16:06:49Z

    Merged version from original poi trunk, and resolved arising problems.
   
    Fixed issues with comments-shifting while column shifting.
    Changed case with shifting columns to negative index. Now it raises exception.
    Introduced ColumnShifter and RowShifter instead of ShiftingManager.
    Added column-shifting methods again.
    Changed project's name back to ApachePOI

commit 59aad5b2c2943ab2df3031de1a6b2289f812aa0e
Author: zmau <drjovanovic@...>
Date:   2017-11-10T16:06:49Z

    Merged version from original poi. Fixed comments shifting. And more.
   
    Merged version from original poi trunk, and resolved arising problems.
    Fixed issues with comments-shifting while column shifting.
    Changed case with shifting columns to negative index. Now it raises exception.
    Introduced ColumnShifter and RowShifter instead of ShiftingManager.
    Added column-shifting methods again.
    Changed project's name back to ApachePOI

commit 3073d48039e41d898109acc954a45bd8a6b3ae16
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-11T22:26:33Z

    Merge branch 'trunk' into trunk

commit fb70bc3694ea9c57ca91ef9496640b71fbb30091
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-12T12:34:14Z

    Refactored column shifting
   
    It's not generic cloning solution any more. In XSSF it is now real shifting. In HSSF and SXSSF it is not implemented yet.
    Also :
    - added checking of cross-sheet references, styles, strings and boolean values;
    - removed XSSFShiftingManager.

commit 7f30d161719e5496f92c3e95cc0a524293c396d1
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-12T12:34:26Z

    Merge remote-tracking branch 'origin/trunk' into trunk

commit 1f0a8c4fd178c39b099dd9dddaab7f83cba82cce
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-12T21:52:28Z

    HSSF column shifting
   
    Improved HSSFSheet.shiftColumns().
    Implemented column shifting for HSSFRow .
    Made content of TestXSSFSheetShiftColumns generic - now it works for both HSSF and XSSF.
    Created ColumnShifting test classes for both XSSF and HSSF variations.

commit 12e5c339bc14b00a116ce8f12b1751ae7b3781e0
Author: Dragan Jovanović <drjovanovic@...>
Date:   2017-11-13T13:51:47Z

    Added JUnit test for new cell shifting methods XSSFRow and HSSFRow.
   
    Also added some input validations and some javadoc.

commit f2ca9a49b3d47dc6b5fc5db217742e63251d755d
Author: zmau <drjovanovic@...>
Date:   2017-11-14T07:30:27Z

    Merge remote-tracking branch 'refs/remotes/origin/trunk'
   
    Conflicts:
    src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
    src/java/org/apache/poi/ss/usermodel/helpers/ColumnShifter.java
    src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRow.java
    src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
    src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetShiftColumns.java
    src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftColumns.java
    src/testcases/org/apache/poi/xssf/usermodel/helpers/XSSFColumnShifterTest.java

commit 24b5e3f0911b7095be85dd5c6399839c318fdd6f
Author: pj.fanning <pj.fanning@...>
Date:   2018-01-20T23:31:05Z

    Merge branch 'upstream-trunk' into zmau-trunk

commit d5b43fad2a7e019cdcc2348a58a4a743e50178a5
Author: Dragan Jovanović <drjovanovic@...>
Date:   2018-01-22T12:09:36Z

    removed dependencies from ss to xssf
   
    Compeletely separated HSSF and XSSF versions of test. XSSF test works good. HSSF test does not, since I did not implement everything for hssf.

commit 8119e27bea73bddb01821c511f61f0bb025ccf00
Author: pj.fanning <pj.fanning@...>
Date:   2018-01-22T12:11:01Z

    Merge branch 'trunk' of https://github.com/zmau/poi into zmau-trunk

commit 612935a73082acbb946e9afaea72da9bb5dc35ae
Author: Dragan Jovanović <drjovanovic@...>
Date:   2018-01-22T13:41:57Z

    made a temporal workaround to make TestHSSFSheetShiftColumns tests pass
   
    Made empty override versions in TestHSSFSheetShiftColumns for all BaseTestSheetShiftColumns methods which fail for hssf.
    After appropriate hssf code is implemented, those methods should be removed, in order to re-enable original test methods from BaseTestSheetShiftColumns class.

commit 4d7a0488a0bc311e3ca7647c5be45917bcfc94c9
Author: Dragan Jovanović <drjovanovic@...>
Date:   2018-01-22T14:05:43Z

    added a reference to bugzilla task

commit 852fe7c6425ed61a96c6a4b91949891887c44aea
Author: pj.fanning <pj.fanning@...>
Date:   2018-01-22T14:34:48Z

    Merge branch 'trunk' of https://github.com/zmau/poi into zmau-trunk

commit f71773c3666c217a1b25a371b48800f237547784
Author: Dragan Jovanović <drjovanovic@...>
Date:   2018-01-22T15:36:38Z

    Merge pull request #2 from pjfanning/zmau-trunk
   
    Rebase with apache/poi trunk

commit 40a0f1b595cf2a0bdeb26d56194c0b9bac31dbde
Author: zmau <drjovanovic@...>
Date:   2018-01-24T10:04:32Z

    Disabled testing for two non-implemented methods

commit 88dfeba348da2c54595df14d770cf83481ef1522
Author: zmau <drjovanovic@...>
Date:   2018-01-30T11:57:27Z

    RangeCopier does copy-paste operation on sheet regions

commit 3708d40f27d80aee9373441bb03cee397048a994
Author: zmau <drjovanovic@...>
Date:   2018-01-30T11:59:11Z

    removed some unnecessery code from test class

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] poi pull request #94: New module RangeCopier.

asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/poi/pull/94


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]