[GitHub] poi pull request #84: Simplify code for writing SXSSF chars

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] poi pull request #84: Simplify code for writing SXSSF chars

tuean
GitHub user pjfanning opened a pull request:

    https://github.com/apache/poi/pull/84

    Simplify code for writing SXSSF chars

    Related to https://bz.apache.org/bugzilla/show_bug.cgi?id=61792
   
    I think this code is easier to read than the existing code. The unit tests pass but I suspect that we might need to test this change with a larger set of test data.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pjfanning/poi sxssf-simplify-chars

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
   
----
commit 65c1356225438026acfd57cff9e78504a6478b3e
Author: pj.fanning <[hidden email]>
Date:   2017-12-05T21:48:50Z

    Simplify code for writing SXSSF chars

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]