[GitHub] poi pull request #74: Remove the useless condition.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] poi pull request #74: Remove the useless condition.

tuean
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/poi/pull/74

    Remove the useless condition.

    The value of the condition "numChars < 0" has been narrowed by a previous IfStatement.
    It has no effect on the current control flow.
    http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/poi master3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
   
----
commit 27d81d4211206f881306d11c46be83ee5706e8b3
Author: Kui LIU <[hidden email]>
Date:   2017-10-12T22:12:31Z

    Remove the useless condition.
   
    The value of the condition "numChars < 0" has been narrowed by a previous IfStatement.
    It has no effect on the current control flow.
    http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] poi pull request #74: Remove the useless condition.

tuean
Github user asfgit closed the pull request at:

    https://github.com/apache/poi/pull/74


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]