[GitHub] [poi] mobreza opened a new pull request #184: Super sxssf

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] mobreza opened a new pull request #184: Super sxssf

GitBox

mobreza opened a new pull request #184:
URL: https://github.com/apache/poi/pull/184


   Rebased MR !141 on current master.
   
   https://github.com/apache/poi/pull/141


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] mobreza commented on pull request #184: Super sxssf

GitBox

mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-649980596


   @pjfanning This is to resume discussions and figure out if this code is still useful since it's a year since the previous MR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650119909


   This code does not compile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650121638


   * `protected ISheetInjector createSheetInjector(InputStream xis) throws IOException` is now correct
   * I don't like the SuperSXSSF names, can we use EmittingSXSSF instead?
   
   The workbook constructor does not compile but this does
   
   ```
       public EmittingSXSSFWorkbook(XSSFWorkbook workbook, int rowAccessWindowSize) {
           super(workbook, rowAccessWindowSize, false, false);
       }
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] asfgit closed pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

asfgit closed pull request #184:
URL: https://github.com/apache/poi/pull/184


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650742399


   Thanks. Merged with https://github.com/apache/poi/commit/f06c45421b1904f196f6aa4c2f99989a1f3185c6
   
   We can treat this as beta for now, as I expect that we might need to add some checks to handle edge cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] mobreza commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650743781


   I'll check our existing code that uses this extension. What's the URL of the maven SNAPSHOTS repository?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650744038


   when https://builds.apache.org/view/P/view/POI/job/POI-DSL-1.8/1011/ completes - check https://builds.apache.org/view/P/view/POI/job/POI-DSL-1.8/lastSuccessfulBuild/artifact/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] mobreza commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650744445


   Thanks, will have a look. I was expecting it at https://repository.apache.org/content/groups/snapshots.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650744641


   https://github.com/mobreza/poi/pull/1#issuecomment-650729604 provides an example of how to use code (except the `SuperSXXSF` classes are renamed as `EmittingSXXSF`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650756831


   @mobreza I'm struggling to think of a good name for these classes. SuperSXSSF was too vague but EmittingSXSSF is not right either. How about DeferredSXSSF or LazySXSSF because of the fact that the actual generation of the rows is delayed until you start writing to the output stream?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] mobreza commented on pull request #184: Super sxssf

GitBox
In reply to this post by GitBox

mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650908411


   Migration from 3.17 (!) to 5.0.0-SNAPSHOT required renaming the `SuperSXSSF*` to `EmittingSXSSF*` and some minor updates: https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/compare/master...apache-poi-5.0.0-SNAPSHOT
   
   I didn't experience any problems with generating Excel files. Downloads start immediately and canceling the download request results in ending the database scan:
   
   ```
   07:06:04,435 qtp1795970853-260  WARN o.g.s.s.i.DownloadServiceImpl:277 - Writing Excel to output stream
   07:06:08,744 qtp1795970853-260  WARN o.g.s.s.i.DownloadServiceImpl:206 - Error generating: org.eclipse.jetty.io.EofException
   07:06:08,749 qtp1795970853-260  WARN o.g.s.a.v.AccessionController:553 - Download was aborted: Closed
   ```
   
   Our code uses [templates](https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/compare/master...apache-poi-5.0.0-SNAPSHOT#e6dd878cf3275b5e86d2c89ce08d0fa9c0291a93_227_226) and [blank workbooks](https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/compare/master...apache-poi-5.0.0-SNAPSHOT#e6dd878cf3275b5e86d2c89ce08d0fa9c0291a93_227_226).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]