[GitHub] [poi] aschott-looker opened a new pull request #229: Allow negative numbers in conditional part of format string

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] aschott-looker opened a new pull request #229: Allow negative numbers in conditional part of format string

GitBox

aschott-looker opened a new pull request #229:
URL: https://github.com/apache/poi/pull/229


   * Negative numbers do not work as expected if they are used in the conditional part of a format string. For example, using `[<-10]#" Wow"` will blow up (poi thinks it is an elapsed time format).
   * The fix was pretty straightforward but Excel itself does not seem to support this case very well either. If you do `=TEXT(-20, [<-10]#" Wow")`, you'd expect an output of `-20 Wow` but you actually get `20 Wow`. Oddly enough, `>` works just fine. For example, `=TEXT(-5, [>-10]#" Wow")` correctly outputs `-5 Wow`.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] centic9 commented on pull request #229: Allow negative numbers in conditional part of format string

GitBox

centic9 commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-793544990


   The included test-file seems to be an empty file, is this intended?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] aschott-looker commented on pull request #229: Allow negative numbers in conditional part of format string

GitBox
In reply to this post by GitBox

aschott-looker commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-794250839


   It's an XLSX file. GitHub can't render the diff.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] aschott-looker commented on pull request #229: Allow negative numbers in conditional part of format string

GitBox
In reply to this post by GitBox

aschott-looker commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-801317185


   @centic9 -- Any thoughts on this change/estimation on when this would be available in a new POI release? We are relying on this functionality working and it would be great to not have to fork the repo.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] aschott-looker edited a comment on pull request #229: Allow negative numbers in conditional part of format string

GitBox
In reply to this post by GitBox

aschott-looker edited a comment on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-801317185


   @centic9 -- Any thoughts on this change/estimation on when this would be available in a new POI release? We are trying to transition from https://github.com/SheetJS/ssf to this library and would be great to not have to fork this repo.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] centic9 commented on pull request #229: Allow negative numbers in conditional part of format string

GitBox
In reply to this post by GitBox

centic9 commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-802695291


   Applied to trunk via https://svn.apache.org/viewvc?view=revision&revision=1887802 but I cannot state when exactly this will be released, as the developer community did not decide fully on the next release yet.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] asfgit closed pull request #229: Allow negative numbers in conditional part of format string

GitBox
In reply to this post by GitBox

asfgit closed pull request #229:
URL: https://github.com/apache/poi/pull/229


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]