[GitHub] [poi] RemboL opened a new pull request #189: Move date parsing logic to DateParser

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] RemboL opened a new pull request #189: Move date parsing logic to DateParser

GitBox

RemboL opened a new pull request #189:
URL: https://github.com/apache/poi/pull/189


   Recently I implemented DateValue function that would parse dates in different formats.
   
   Since then, I noticed that there are other functions (YEARFRAC, in particular) that use date parsing logic and that they are using a class DateParser. This brought my attention, because DateParser is unable to parse dates in other formats, like 'yyyy-MM-dd'.
   
   I think it would make sense to use the same logic for date parsing in all places, so I moved my code from DateValue function to DateParser. Since both DateParser and DateValue tests are still green without any changes, I think this refactor is valid.
   
   I also moved DateParser from atp package to util, since it is used outside atp now - although I see that it might raise some flags, since it is a public class and theoretically it might break compatibility for other projects that might be using DateParser - please advice, whether it is acceptable to move this class or should it be left in current package.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] asfgit closed pull request #189: Move date parsing logic to DateParser

GitBox

asfgit closed pull request #189:
URL: https://github.com/apache/poi/pull/189


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #189: Move date parsing logic to DateParser

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #189:
URL: https://github.com/apache/poi/pull/189#issuecomment-672689340


   Thanks - merged with https://github.com/apache/poi/commit/e86ba86f2dbc6c48b34a24bed3cbb2ba2e087648


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]