[GitHub] [poi] MariusVolkhart opened a new pull request #224: Use Log4j 2 for logging

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart opened a new pull request #224: Use Log4j 2 for logging

GitBox

MariusVolkhart opened a new pull request #224:
URL: https://github.com/apache/poi/pull/224


   Hi devs! Here is iteration 1 of switching the logging to be entirely based on Log4j 2 and removing `POILogger` & co. It would be helpful if you could try this out in your workflows (running/analyzing integration tests, jenkins/sonar intergrations, OSGi, etc) and see if there are things you're now missing. The code "works" but I might have configured something incorrectly.
   
   I want to give a special thanks to @pjfanning whose previous work for adding a SLF4J integration for `POILogger` made it a lot easier to figure out where in all the ant/gradle/maven build files dependencies needed to be changed.
   
   As discussed on the mailing list, this change it targeted for 5.1.0. If/When there are no problems, I'll take this over to SVN.
   
   _Commit message below_
   This removes the POILogger and POILogFactory mechanism for logging. This mechanism was created at a time when the Java landscape looked very different than it does today.
   
   Log4j 2 is an Apache Foundation project that is well maintained and is widely regarded as having good performance and capabilities. We use only the Log4j API artifact. This lets application developers choose how they want to capture logging events if at all. Integrations with Log4j 2 Core and Logback are available from the Log4j project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on a change in pull request #224: Use Log4j 2 for logging

GitBox

MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567910736



##########
File path: build.xml
##########
@@ -289,7 +288,7 @@ under the License.
     <dependency prefix="main.byte-buddy" artifact="net.bytebuddy:byte-buddy:1.10.19" usage="main-tests"/>
     <dependency prefix="main.byte-buddy-agent" artifact="net.bytebuddy:byte-buddy-agent:1.10.19" usage="main-tests"/>
     <dependency prefix="main.objenesis" artifact="org.objenesis:objenesis:3.1" usage="main-tests"/>
-    <dependency prefix="main.slf4j-simple" artifact="org.slf4j:slf4j-simple:1.7.30" usage="main-tests"/>
+    <dependency prefix="main.log4j-core" artifact="org.apache.logging.log4j:log4j-core:2.14.0" usage="main-tests"/>

Review comment:
       We could keep using `slf4j-simple`, but would need to add an additional "bridge" dependency

##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<Configuration status="WARN" name="console">
+  <Appenders>
+    <Console name="Console" target="SYSTEM_OUT">
+      <PatternLayout pattern="%d [%t] %-5p %c - %m%n" />
+    </Console>
+  </Appenders>
+  <Loggers>
+    <Logger name="org.apache.poi.poifs.nio.FileBackedDataSource" level="ERROR" />
+    <Logger name="org.apache.poi.hdgf.chunks.Chunk" level="FATAL" />
+    <Logger name="org.apache.poi.hpsf.CodePageString" level="ERROR" />
+    <Logger name="org.apache.poi.hdgf.chunks.ChunkFactory" level="ERROR" />
+    <Logger name="org.apache.poi.hslf.model.textproperties.BitMaskTextProp" level="ERROR" />
+    <Logger name="org.apache.poi.hslf.usermodel.HSLFTextParagraph" level="ERROR" />
+    <Logger name="org.apache.poi.openxml4j.opc.ZipPackage" level="ERROR" />
+    <Logger name="org.apache.poi.POIDocument" level="WARN" />
+    <Logger name="org.apache.poi.openxml4j.opc.OPCPackage" level="ERROR" />
+    <Logger name="org.apache.poi.xssf.usermodel.XSSFWorkbook" level="ERROR" />
+    <Logger name="org.apache.poi.hslf.usermodel.HSLFGroupShape" level="WARN" />
+    <Logger name="org.apache.poi.hslf.record.Record" level="ERROR" />

Review comment:
       These logger/level pairs are an aggregation of various logging files I saw

##########
File path: legal/LICENSE
##########
@@ -285,29 +285,9 @@ CurvesAPI / Curve API
     NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
     SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-SLF4J library (slf4j-api-*.jar)
+Log4j 2 library (log4j-api-*.jar)
 
-    Copyright (c) 2004-2017 QOS.ch
-    All rights reserved.
-
-    Permission is hereby granted, free  of charge, to any person obtaining
-    a  copy  of this  software  and  associated  documentation files  (the
-    "Software"), to  deal in  the Software without  restriction, including
-    without limitation  the rights to  use, copy, modify,  merge, publish,
-    distribute,  sublicense, and/or sell  copies of  the Software,  and to
-    permit persons to whom the Software  is furnished to do so, subject to
-    the following conditions:
-
-    The  above  copyright  notice  and  this permission  notice  shall  be
-    included in all copies or substantial portions of the Software.
-
-    THE  SOFTWARE IS  PROVIDED  "AS  IS", WITHOUT  WARRANTY  OF ANY  KIND,
-    EXPRESS OR  IMPLIED, INCLUDING  BUT NOT LIMITED  TO THE  WARRANTIES OF
-    MERCHANTABILITY,    FITNESS    FOR    A   PARTICULAR    PURPOSE    AND
-    NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-    LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-    OF CONTRACT, TORT OR OTHERWISE,  ARISING FROM, OUT OF OR IN CONNECTION
-    WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+    Apache License Version 2.0

Review comment:
       Not sure if this is necessary, or the right way to document this?

##########
File path: osgi/pom.xml
##########
@@ -104,7 +103,8 @@
                             commons-math3,
                             commons-compress,
                             commons-collections4,
-                            commons-codec
+                            commons-codec,
+                            log4j-api

Review comment:
       I don't know how this works or how to verify it. I'd appreciate any help or guidance.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567934075



##########
File path: build.xml
##########
@@ -289,7 +288,7 @@ under the License.
     <dependency prefix="main.byte-buddy" artifact="net.bytebuddy:byte-buddy:1.10.19" usage="main-tests"/>
     <dependency prefix="main.byte-buddy-agent" artifact="net.bytebuddy:byte-buddy-agent:1.10.19" usage="main-tests"/>
     <dependency prefix="main.objenesis" artifact="org.objenesis:objenesis:3.1" usage="main-tests"/>
-    <dependency prefix="main.slf4j-simple" artifact="org.slf4j:slf4j-simple:1.7.30" usage="main-tests"/>
+    <dependency prefix="main.log4j-core" artifact="org.apache.logging.log4j:log4j-core:2.14.0" usage="main-tests"/>

Review comment:
       best to drop slf4j if log4j2 is what we really want to support




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567935392



##########
File path: osgi/pom.xml
##########
@@ -104,7 +103,8 @@
                             commons-math3,
                             commons-compress,
                             commons-collections4,
-                            commons-codec
+                            commons-codec,
+                            log4j-api

Review comment:
       remove any unnecessary slf4j or commons-logging entries




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567936892



##########
File path: build.gradle
##########
@@ -437,6 +439,7 @@ project('scratchpad') {
         compile project(':main')
         compile "commons-codec:commons-codec:${commonsCodecVersion}"
         compile "org.apache.commons:commons-math3:${commonsMathVersion}"
+        implementation "org.apache.logging.log4j:log4j-api:${log4jVersion}"

Review comment:
       can you stick with 'compile' and we can change all compile to implementation later

##########
File path: build.gradle
##########
@@ -437,6 +439,7 @@ project('scratchpad') {
         compile project(':main')
         compile "commons-codec:commons-codec:${commonsCodecVersion}"
         compile "org.apache.commons:commons-math3:${commonsMathVersion}"
+        implementation "org.apache.logging.log4j:log4j-api:${log4jVersion}"

Review comment:
       can you stick with 'compile' and we can change all compile to implementation later?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

centic9 commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r568637101



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       Is there a way to move the two xml-configuration files away from the root-directory?
   
   For other logging frameworks these are loaded via the classpath, so would go to the "src/resources".
   
   Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r569002478



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       > Is there a way to move the two xml-configuration files away from the root-directory?
   >
   > For other logging frameworks these are loaded via the classpath, so would go to the "src/resources".
   Indeed. Our tests use Log4j 2 Core as the logging backend, which also loads configuration from the classpath. So in the case of the POI tests, which use the `log4j2-no-logging.xml` configuration by default, I could place a copy of that config into each test sourceset's `src/resources` directory, and wouldn't need to specify the `log4j.configurationFile` system property.
   
   To then get the console behavior, one option is to continue using the `log4j.configurationFile` system property as this code currently does. Another option is to combine the configurations and the developer running the tests comments/uncomments lines of code in the configuration as they need.
   
   I don't have a strong opinion on one method or another.
   
   > Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property?
   
   I'll answer assuming the application developer is also using Log4j 2 Core as the backend (same as the POI tests in this PR), but I assume similar rules apply if they are using Logback or another logging backend.
   
   The existing logging configuration that the developer has will decide how POI log messages are captured. That configuration likely lives at `main/src/resources` and is loaded from the classpath, but it is possible the developer has previously chosen to use the system property, is doing programmatic configuration, etc.
   
   Here are some examples of what a developer might indicate in their configuration:
   1. Capture all POI logs at the same level as their application logging. Basically, they just say "I want all messages `INFO` and higher, regardless where they come from", and POI messages are included in that.
   2. Capture only messages they opt in to. They might say "Only collect messages from package `com.myapplication.*` that are INFO and higher". POI messages are excluded.
   3. Capture all messages except POI. They might say "Collect everything _except_ `org.apache.poi.*`."
   
   I hope that makes sense. If not, let me know! I haven't started on the changes to the logging documentation for the site, but if seeing those changes as part of the PR would be helpful, I can work on those in the next few days while this sits :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r569002478



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       > Is there a way to move the two xml-configuration files away from the root-directory?
   >
   > For other logging frameworks these are loaded via the classpath, so would go to the "src/resources".
   Indeed. Our tests use Log4j 2 Core as the logging backend, which also loads configuration from the classpath. So in the case of the POI tests, which use the `log4j2-no-logging.xml` configuration by default, I could place a copy of that config into each test sourceset's `src/resources` directory, and wouldn't need to specify the `log4j.configurationFile` system property.
   
   To then get the console behavior, one option is to continue using the `log4j.configurationFile` system property as this code currently does. Another option is to combine the configurations and the developer running the tests comments/uncomments lines of code in the configuration as they need.
   
   I don't have a strong opinion on one method or another.
   
   > Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property?
   
   I'll answer assuming the application developer is also using Log4j 2 Core as the backend (same as the POI tests in this PR), but I assume similar rules apply if they are using Logback or another logging backend.
   
   The existing logging configuration that the developer has will decide how POI log messages are captured. That configuration likely lives at `main/src/resources` and is loaded from the classpath, but it is possible the developer has previously chosen to use the system property, is doing programmatic configuration, etc.
   
   Here are some examples of what a developer might indicate in their configuration:
   1. Capture all POI logs at the same level as their application logging. Basically, they just say "I want all messages `INFO` and higher, regardless where they come from", and POI messages are included in that.
   2. Capture only messages they opt in to. They might say "Only collect messages from package `com.myapplication.*` that are INFO and higher". POI messages are excluded.
   3. Capture all messages except POI. They might say "Collect everything _except_ `org.apache.poi.*`."
   
   I hope that makes sense. If not, let me know! I haven't started on the changes to the logging documentation for the site, but if seeing those changes as part of the PR would be helpful, I can work on those in the next few days while this sits :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

centic9 commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r568637101



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       Is there a way to move the two xml-configuration files away from the root-directory?
   
   For other logging frameworks these are loaded via the classpath, so would go to the "src/resources".
   
   Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r569002478



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       > Is there a way to move the two xml-configuration files away from the root-directory?
   >
   > For other logging frameworks these are loaded via the classpath, so would go to the "src/resources".
   
   Indeed. Our tests use Log4j 2 Core as the logging backend, which also loads configuration from the classpath. So in the case of the POI tests, which use the `log4j2-no-logging.xml` configuration by default, I could place a copy of that config into each test sourceset's `src/resources` directory, and wouldn't need to specify the `log4j.configurationFile` system property.
   
   To then get the console behavior, one option is to continue using the `log4j.configurationFile` system property as this code currently does. Another option is to combine the configurations and the developer running the tests comments/uncomments lines of code in the configuration as they need.
   
   I don't have a strong opinion on one method or another.
   
   > Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property?
   
   I'll answer assuming the application developer is also using Log4j 2 Core as the backend (same as the POI tests in this PR), but I assume similar rules apply if they are using Logback or another logging backend.
   
   The existing logging configuration that the developer has will decide how POI log messages are captured. That configuration likely lives at `main/src/resources` and is loaded from the classpath, but it is possible the developer has previously chosen to use the system property, is doing programmatic configuration, etc.
   
   Here are some examples of what a developer might indicate in their configuration:
   1. Capture all POI logs at the same level as their application logging. Basically, they just say "I want all messages `INFO` and higher, regardless where they come from", and POI messages are included in that.
   2. Capture only messages they opt in to. They might say "Only collect messages from package `com.myapplication.*` that are INFO and higher". POI messages are excluded.
   3. Capture all messages except POI. They might say "Collect everything _except_ `org.apache.poi.*`."
   
   I hope that makes sense. If not, let me know! I haven't started on the changes to the logging documentation for the site, but if seeing those changes as part of the PR would be helpful, I can work on those in the next few days while this sits :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r574903527



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       @centic9 I took a stab at moving the logging configs to be more how a project typically would use them. See https://github.com/MariusVolkhart/poi/pull/1 for the changes. If you'd like those changes pulled in, let me know.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

centic9 commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r575051285



##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       Thanks for the effort, to me it looks clearer this way as it makes it easy to see that these files are only used for tests and not deployed as part of the released library itself.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] kiwiwings commented on pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

kiwiwings commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782765896


   When is this applied to SVN?
   I'd like to change to Log4j 2 also on XmlBeans too, but I think this makes only sense, when POI is already migrated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

MariusVolkhart commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782766136


   I was waiting for 5.0.1 to be released, but I can commit this to SVN this
   weekend.
   
   On Sun, Feb 21, 2021, 00:37 Andreas Beeker <[hidden email]> wrote:
   
   > When is this applied to SVN?
   > I'd like to change to Log4j 2 also on XmlBeans too, but I think this makes
   > only sense, when POI is already migrated.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/poi/pull/224#issuecomment-782765896>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AANBLTJNG7W3SX422HJTLS3TABBTJANCNFSM4W47KSAQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] kiwiwings commented on pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

kiwiwings commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782771057


   SLF4J is missing in XmlBeans module-info, but it's used. So we might want to release a new version there anyway, i.e. before POI 5.0.1.
   And if the logging matches that would make things smoother I guess ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782771632


   @kiwiwings the logging in xmlbeans is minimal and the slf4j was only added recently by me - since the last release so it could be replaced by log4j2x without any major impact - if we make these logging changes, it does seem like the next releases should be XmlBeans 5.0.0 and POI 6.0.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] asfgit closed pull request #224: Use Log4j 2 for logging

GitBox
In reply to this post by GitBox

asfgit closed pull request #224:
URL: https://github.com/apache/poi/pull/224


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]