[GitHub] [poi] MariusVolkhart opened a new pull request #197: Modify test utility class to compile on OpenJ9

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart opened a new pull request #197: Modify test utility class to compile on OpenJ9

GitBox

MariusVolkhart opened a new pull request #197:
URL: https://github.com/apache/poi/pull/197


   The HeapDump class was referencing a function that exists only on VMs that use HotSpot. Other VMs, such as OpenJ9 don't have this function, so the tests did not compile.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on a change in pull request #197: Modify test utility class to compile on OpenJ9

GitBox

pjfanning commented on a change in pull request #197:
URL: https://github.com/apache/poi/pull/197#discussion_r522931550



##########
File path: src/integrationtest/org/apache/poi/stress/HeapDump.java
##########
@@ -42,7 +43,17 @@ Licensed to the Apache Software Foundation (ASF) under one or more
     public static void dumpHeap(String fileName, boolean live) throws IOException {
         // initialize hotspot diagnostic MBean
         initHotspotMBean();
-        hotspotMBean.dumpHeap(fileName, live);
+        throw new NotImplementedException("Developer: You need to uncomment the corresponding line here.");

Review comment:
       I'd prefer if this was modified to use Java reflection




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] MariusVolkhart commented on a change in pull request #197: Modify test utility class to compile on OpenJ9

GitBox
In reply to this post by GitBox

MariusVolkhart commented on a change in pull request #197:
URL: https://github.com/apache/poi/pull/197#discussion_r523114918



##########
File path: src/integrationtest/org/apache/poi/stress/HeapDump.java
##########
@@ -42,7 +43,17 @@ Licensed to the Apache Software Foundation (ASF) under one or more
     public static void dumpHeap(String fileName, boolean live) throws IOException {
         // initialize hotspot diagnostic MBean
         initHotspotMBean();
-        hotspotMBean.dumpHeap(fileName, live);
+        throw new NotImplementedException("Developer: You need to uncomment the corresponding line here.");

Review comment:
       Done! @pjfanning mind taking another look? I tested w/ OpenJ9 11 and OpenJDK 16




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] asfgit closed pull request #197: Modify test utility class to compile on OpenJ9

GitBox
In reply to this post by GitBox

asfgit closed pull request #197:
URL: https://github.com/apache/poi/pull/197


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] pjfanning commented on pull request #197: Modify test utility class to compile on OpenJ9

GitBox
In reply to this post by GitBox

pjfanning commented on pull request #197:
URL: https://github.com/apache/poi/pull/197#issuecomment-726924184


   Thanks. Merged with https://github.com/apache/poi/commit/00b9048d59e8800a59560425d11bbe13d44a60a6 - will check later to see if there any problems with the Jenkins builds.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]