[GitHub] [poi] FiddlersCode opened a new pull request #212: 65023 add col bugfix

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] FiddlersCode opened a new pull request #212: 65023 add col bugfix

GitBox

FiddlersCode opened a new pull request #212:
URL: https://github.com/apache/poi/pull/212


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] jzheng2017 commented on a change in pull request #212: 65023 add col bugfix

GitBox

jzheng2017 commented on a change in pull request #212:
URL: https://github.com/apache/poi/pull/212#discussion_r547467168



##########
File path: src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestColumn.java
##########
@@ -0,0 +1,82 @@
+/* ====================================================================
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+==================================================================== */
+
+package org.apache.poi.xwpf.usermodel;
+
+import org.apache.poi.xwpf.XWPFTestDataSamples;
+import org.junit.Test;
+import java.io.IOException;
+import static org.junit.Assert.assertEquals;
+
+public class TestColumn {
+    @Test
+    public void testAddNewCol() throws IOException {

Review comment:
       Test name should be more descriptive.
   
   ```suggestion
       public void testAddNewColWithCorrectAmountOfColumns() throws IOException {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [poi] asfgit closed pull request #212: 65023 add col bugfix

GitBox
In reply to this post by GitBox

asfgit closed pull request #212:
URL: https://github.com/apache/poi/pull/212


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]