DO NOT REPLY [Bug 34787] New: - [PATCH] stop ddf.EscherClientAnchorRecord breaking on short records

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 34787] New: - [PATCH] stop ddf.EscherClientAnchorRecord breaking on short records

Bugzilla from bugzilla@apache.org
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG?
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34787>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND?
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34787

           Summary: [PATCH] stop ddf.EscherClientAnchorRecord breaking on
                    short records
           Product: POI
           Version: 3.0-dev
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POIFS
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


ddf.EscherClientAnchorRecord assumes that it has 9 2 byte records, and hence is
26 bytes long. In some powerpoint files, it just has 4 2 bytes records, so the
size is only 16 bytes. Because of its assumption, this breaks things.

Attached is a patch to make it check that it has the data before trying to read
the last 5 fields, which stops it breaking on 4 field records. (However, it
makes no attempt to ensure that the first 4 fields correspond to the ones
present in a short record, since there's no guide I can find to explain what the
4 fields in a short record actually correspond to)

--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/