DO NOT REPLY [Bug 21923] - [PATCH] Modify HSSFWorkbook, FormulaParser and SheetReferences to support 3DRefs

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 21923] - [PATCH] Modify HSSFWorkbook, FormulaParser and SheetReferences to support 3DRefs

Bugzilla from bugzilla@apache.org
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG?
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=21923>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND?
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=21923





------- Additional Comments From [hidden email]  2005-05-17 22:29 -------
I've been trying to bring the patch foward and ran into an interesting
chicken/egg problem.  In every Ptg class, the toForumlaString method takes a
second parameter of type Workbook.  If there's no way to get a Workbook from an
HSSFWorkbook, none of those parameters can ever be filled with anything other
than null.  I was reworking the patch slightly from the mind-set that you can
never obtain an object of type Workbook to pass anywhere, so I was removing
references of Workbook from the FormulaParser.  Then I found all the Ptg's.
From a quick analysis, it looks like it can safely be removed from all of them
(it's unused in 90% of them, only Area3DPtg and Ref3DPtg actually use it and
it's just to get the sheet references).  The only one I'm concerned about is the
NamePtg.

I'm kind of hesitant to produce a patch that touches that many files, but it
really does seem to me that the whole involvement of Workbook in the formula
related classes is completely useless and can never be utilized.  Period.

Should I continue?

--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/