See <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/213/display/redirect?page=changes>
Changes:
[Marius Volkhart] Fix bug with record indexes for HSSF Workbooks
We have encountered workbooks that do not have a TabIdRecord (see 55982.xls). However, the WorkbookRecordList#updateRecordPos() method would still increment the position of the TabIdRecord for such workbooks. Changing the default position of the record from 0 to -1 indicates that the record position has now been set.
This bug was discovered while adding support for editing pictures in HSSF documents.
------------------------------------------
[...truncated 721.91 KB...]
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java>:120: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if columnIndex < 0 or greater than the maximum number of supported columns
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java>:137: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if columnIndex < 0 or greater than a maximum number of supported columns
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java>:195: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if rowNum < 0
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java>:235: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if cellnum < 0 or the specified MissingCellPolicy is invalid
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:265: error: unknown tag: clrScheme
[javadoc] * Index into the <clrScheme> collection, referencing a particular <sysClr> or
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:265: error: unknown tag: sysClr
[javadoc] * Index into the <clrScheme> collection, referencing a particular <sysClr> or
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:266: error: unknown tag: srgbClr
[javadoc] * <srgbClr> value expressed in the Theme part.
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:274: error: unknown tag: clrScheme
[javadoc] * Index into the <clrScheme> collection, referencing a particular <sysClr> or
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:274: error: unknown tag: sysClr
[javadoc] * Index into the <clrScheme> collection, referencing a particular <sysClr> or
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:275: error: unknown tag: srgbClr
[javadoc] * <srgbClr> value expressed in the Theme part.
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFColor.java>:385: error: tag not supported in the generated HTML version: tt
[javadoc] * Checked type cast <tt>color</tt> to an XSSFColor.
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java>:4173: error: tag not supported in the generated HTML version: tt
[javadoc] * Returns <tt>null</tt> if no sheet tab color is set.
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFConditionalFormatting.java>:53: error: tag not supported in the generated HTML version: tt
[javadoc] * @return array of <tt>CellRangeAddress</tt>s. Never <code>null</code>
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFName.java>:86: error: tag not allowed here: <li>
[javadoc] * <li> this defined name refers to a range to which an advanced filter has been
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFName.java>:88: error: tag not allowed here: <li>
[javadoc] * <li> This defined name refers to a range to which an AutoFilter has been
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFName.java>:146: error: tag not allowed here: <blockquote>
[javadoc] * <pre><blockquote>
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFName.java>:165: error: unexpected end tag: </p>
[javadoc] * </p>
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRow.java>:106: error: unknown tag: Cell
[javadoc] * for (Iterator<Cell> it = row.cellIterator(); it.hasNext(); ) {
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRow.java>:193: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if columnIndex < 0 or greater than 16384,
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRow.java>:207: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if the specified cell type is invalid, columnIndex < 0
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRow.java>:415: error: malformed HTML
[javadoc] * @throws IllegalArgumentException if rowNum < 0 or greater than 1048575
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheetConditionalFormatting.java>:59: error: tag not supported in the generated HTML version: tt
[javadoc] * <tt>{@link org.apache.poi.hssf.record.CFRuleBase.ComparisonOperator}</tt>: <p>
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheetConditionalFormatting.java>:70: error: unexpected end tag: </p>
[javadoc] * </p>
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/BreakClear.java>:56: error: tag not allowed here: <li>
[javadoc] * <li> If the parent paragraph is right to left, then these behaviors are
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFAbstractFootnoteEndnote.java>:169: error: unterminated signature
[javadoc] * Inserts an existing {@link XWPFTable) into the arrays bodyElements and tables.
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFAbstractFootnoteEndnote.java>:172: error: unterminated signature
[javadoc] * @param table {@link XWPFTable) to be inserted
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java>:180: error: unknown tag: IRunElement
[javadoc] * @return List<IRunElement>
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFEndnote.java>:60: error: unterminated signature
[javadoc] * the footnote, use {@link XWPFParagraph#addFootnoteReference(XWPFAbstractFootnoteEndnote))}.
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFEndnotes.java>:139: error: exception not thrown: java.io.IOException
[javadoc] * @throws IOException
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFEndnotes.java>:151: error: exception not thrown: java.io.IOException
[javadoc] * @throws IOException
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java>:415: error: unexpected content
[javadoc] * @see (@link UnderlinePatterns}
[javadoc] ^
[javadoc] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java>:441: error: unexpected content
[javadoc] * @see {@link UnderlinePatterns} : all possible patterns that could be applied
[javadoc] ^
[javadoc] 100 errors
[javadoc] 100 warnings
[jar] Building jar: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist/maven/poi-ooxml/poi-ooxml-5.0.1-SNAPSHOT-javadoc.jar>
assemble:
[zip] Building zip: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist/poi-bin-5.0.1-SNAPSHOT-20210227.zip>
[tar] Building tar: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/213/artifact/build/dist/poi-bin-5.0.1-SNAPSHOT-20210227.tar.gz>
[zip] Building zip: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist/poi-src-5.0.1-SNAPSHOT-20210227.zip>
[tar] Building tar: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/213/artifact/build/dist/poi-src-5.0.1-SNAPSHOT-20210227.tar.gz>
[echo] Creating Maven POMs
maven-poms:
[copy] Copying 7 files to <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist/maven>
[echo] Maven POMs are located in <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist>
[echo] Use ant dist-nexus to deploy the artifacts in the remote repository
[echo] Distribution located in <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist>
[echo] Use "ant dist-checksum" to create sha256/sha512 checksums and GPG signatures
findbugs:
[mkdir] Created dir: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/config>
[get] Getting:
https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs/4.2.0/spotbugs-4.2.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/spotbugs.jar>
[get] Getting:
https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs-ant/4.2.0/spotbugs-ant-4.2.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/spotbugs-ant.jar>
[get] Getting:
https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs-annotations/4.2.0/spotbugs-annotations-4.2.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/spotbugs-annotations.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/dom4j/dom4j/2.1.3/dom4j-2.1.3.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/dom4j-2.1.3.jar>
[get] Getting:
https://repo1.maven.org/maven2/jaxen/jaxen/1.2.0/jaxen-1.2.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/jaxen-1.2.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/apache/bcel/bcel/6.5.0/bcel-6.5.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/bcel-6.5.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/slf4j/slf4j-api/1.8.0-beta4/slf4j-api-1.8.0-beta4.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/slf4j-api-1.8.0-beta4.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.11/commons-lang3-3.11.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/commons-lang3-3.11.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/apache/commons/commons-text/1.9/commons-text-1.9.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/commons-text-1.9.jar>
[get] Getting:
https://repo1.maven.org/maven2/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/jcip-annotations-1.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/jsr305-3.0.2.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/ow2/asm/asm/9.0/asm-9.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/asm-9.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/ow2/asm/asm-analysis/9.0/asm-analysis-9.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/asm-analysis-9.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/ow2/asm/asm-commons/9.0/asm-commons-9.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/asm-commons-9.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/ow2/asm/asm-tree/9.0/asm-tree-9.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/asm-tree-9.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/ow2/asm/asm-util/9.0/asm-util-9.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/asm-util-9.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-api/2.14.0/log4j-api-2.14.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/log4j-api-2.14.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-core/2.14.0/log4j-core-2.14.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/log4j-core-2.14.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-slf4j18-impl/2.14.0/log4j-slf4j18-impl-2.14.0.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/log4j-slf4j18-impl-2.14.0.jar>
[get] Getting:
https://repo1.maven.org/maven2/net/sf/saxon/Saxon-HE/9.9.1-8/Saxon-HE-9.9.1-8.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/Saxon-HE-9.9.1-8.jar>
[get] Getting:
https://repo1.maven.org/maven2/com/ibm/icu/icu4j/68.2/icu4j-68.2.jar [get] To: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/icu4j-63.1.jar>
[spotbugs] Executing SpotBugs FindBugsTask from ant task
[spotbugs] Running SpotBugs...
[spotbugs] Java Result: 1
[spotbugs] Output saved to build/findbugs.xml
[xslt] Transforming into <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build>
[xslt] Processing <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs.xml> to <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/213/artifact/build/findbugs.html>
[xslt] Loading stylesheet jar:<
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/findbugs/lib/spotbugs.jar!/fancy.xsl>
release-notes:
[copy] Copying 1 file to <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/dist>
rat-check:
[mkdir] Created dir: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build/rat>
[echo]
[echo] *****************************************************
[echo] Summary
[echo] -------
[echo] Generated at: 2021-02-27T01:18:11+00:00
[echo]
[echo] Notes: 0
[echo] Binaries: 114
[echo] Archives: 0
[echo] Standards: 3754
[echo]
[echo] Apache Licensed: 3753
[echo] Generated Documents: 0
[echo]
[echo] JavaDocs are generated, thus a license header is optional.
[echo] Generated files do not require license headers.
[echo]
[echo] 1 Unknown Licenses
[echo]
[echo] *****************************************************
[echo]
[echo] Files with unapproved licenses:
[echo]
[echo] <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/testcases/org/apache/poi/hssf/model/TestWorkbookRecordList.java>
[echo]
[echo] *****************************************************
[echo]
[echo] *****************************************************
[echo] Files with Apache License headers will be marked AL
[echo] Binary files (which do not require any license headers) will be marked B
[echo] Compressed archives will be marked A
[echo] Notices, licenses etc. will be marked N
[echo] !????? <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/testcases/org/apache/poi/hssf/model/TestWorkbookRecordList.java>
[echo]
[echo] *****************************************************
[echo]
[echo] Printing headers for text files without a valid license header...
[echo]
[echo] =====================================================
[echo] == File: <
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/src/testcases/org/apache/poi/hssf/model/TestWorkbookRecordList.java>
[echo] =====================================================
[echo] package org.apache.poi.hssf.model;
[echo]
[echo] import org.apache.poi.hssf.record.chart.ChartRecord;
[echo] import org.apache.poi.hssf.usermodel.HSSFWorkbook;
[echo] import org.junit.jupiter.api.Test;
[echo]
[echo] import java.io.IOException;
[echo]
[echo] import static org.apache.poi.hssf.HSSFTestDataSamples.openSampleWorkbook;
[echo] import static org.junit.jupiter.api.Assertions.assertEquals;
[echo]
[echo] public class TestWorkbookRecordList {
[echo]
[echo] @Test
[echo] public void tabposIsOnlyUpdatedIfWorkbookHasTabIdRecord() throws IOException {
[echo] try (HSSFWorkbook wb = openSampleWorkbook("55982.xls")) {
[echo] WorkbookRecordList records = wb.getInternalWorkbook().getWorkbookRecordList();
[echo] assertEquals(-1, records.getTabpos());
[echo]
[echo] // Add an arbitrary record to the front of the list
[echo] records.add(0, new ChartRecord());
[echo]
[echo] assertEquals(-1, records.getTabpos());
[echo] }
[echo] }
[echo] }
BUILD FAILED
<
https://ci-builds.apache.org/job/POI/job/POI-DSL-1.16/ws/build.xml>:2486: condition satisfied
Total time: 22 minutes 7 seconds
Build step 'Invoke Ant' marked build as failure
[SpotBugs] Skipping execution of recorder since overall result is 'FAILURE'
Archiving artifacts
[Fast Archiver] Compressed 217.62 MB of artifacts by 31.0% relative to #212
Skipping publisher since build result is FAILURE
Recording test results
---------------------------------------------------------------------
To unsubscribe, e-mail:
[hidden email]
For additional commands, e-mail:
[hidden email]
Locked
