[Bug 65026] New: Migrate tests to Junit 5

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 65026] New: Migrate tests to Junit 5

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=65026

            Bug ID: 65026
           Summary: Migrate tests to Junit 5
           Product: POI
           Version: 4.1.x-dev
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: POI Overall
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Junit5 brings a few features missing in Junit4 - namely better support for
parameterized and nested tests.

I've decided to give it a try, and then I was in the middle of migration
purgatory :)

The following changes will be visible after I committed the 1000+ file changes:

a) Junit5 uses different annotations and different packages

b) expected exceptions are now handled via assertThrows

c) ant lacks support for direct test feedback - see
https://bz.apache.org/bugzilla/show_bug.cgi?id=64836
  I'm using a custom test listener to print the summary, but this will only be
shown when all tests of the current module are processed.

*So don't panic when the build seems to hang - you can track the progress in
build/status-as-tests-run.txt*

d) JaCoCo is not handling Junit5 in the "coverage" tag - see
https://github.com/jacoco/jacoco/issues/673
  I've worked around it with the "agent" tag, but I haven't test it yet

e) I've deleted all TestSuites (like AllFormulaTests)  locally, as Junit5
doesn't support declarative test suites currently
(https://github.com/junit-team/junit5/issues/744)

f) I've cleaned most of the cases where an Assertions.assert* is preferred to a
call to .fail()

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 65026] Migrate tests to Junit 5

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=65026

--- Comment #1 from Andreas Beeker <[hidden email]> ---
Applied via r1884783

probably still a few fixes need to be applied to satisfy all Jenkins jobs

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 65026] Migrate tests to Junit 5

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=65026

Andreas Beeker <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Andreas Beeker <[hidden email]> ---
most of the issues with the build are solved - I'm checking now how the gradle
build can be convinced to work again.
closing this ticket, so I don't forget about it ...

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 65026] Migrate tests to Junit 5

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=65026

--- Comment #3 from Dolls France <[hidden email]> ---

[reply] [−]DescriptionAndreas Beeker 2020-12-24 18:23:30 UTC
Junit5 brings a few features missing in Junit4 - namely better support for
parameterized and nested tests.

I've decided to give it a try, and then I was in the middle of migration
purgatory :) https://sex-dolls-europe.com

The following changes will be visible after I committed the 1000+ file changes:

a) Junit5 uses different annotations and different packages

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]