[Bug 63998] New: AreaReference doesn't support sheetName with commas and exclamation marks

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 63998] New: AreaReference doesn't support sheetName with commas and exclamation marks

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63998

            Bug ID: 63998
           Summary: AreaReference doesn't support sheetName with commas
                    and exclamation marks
           Product: POI
           Version: 4.1.x-dev
          Hardware: Macintosh
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Functions in this class are not aware of special characters such as exclamation
mark ! and comma , at all.

AreaReference.generateContiguous and AreaReference.isContiguous are implemented
naively in this sense, which is simply looking for commas as delimiters.


References like these are all valid, but they'll fail unit tests:

'A,Sheet'!$A$1:$A$1
'!and,Sheet'!$A$1:$A$1

The first one fails AreaReference.generateContiguous, and the second one also
fails AreaReference.isContiguous

Sheet name is quoted with single quotation marks (luckily enough, it seems
Excel doesn't allow escaping single quotation marks)


This bug exists in the latest trunk code

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63998] AreaReference doesn't support sheetName with commas and exclamation marks

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63998

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                 OS|                            |All

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63998] AreaReference doesn't support sheetName with commas and exclamation marks

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63998

--- Comment #1 from [hidden email] ---
Created attachment 36947
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36947&action=edit
Proposed patch to fix this issue

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63998] [PATCH] AreaReference doesn't support sheetName with commas and exclamation marks

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63998

Dominik Stadler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
            Summary|AreaReference doesn't       |[PATCH] AreaReference
                   |support sheetName with      |doesn't support sheetName
                   |commas and exclamation      |with commas and exclamation
                   |marks                       |marks

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63998] [PATCH] Support commas, exclamation marks correctly in AreaReference

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63998

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[PATCH] AreaReference       |[PATCH] Support commas,
                   |doesn't support sheetName   |exclamation marks correctly
                   |with commas and exclamation |in AreaReference
                   |marks                       |

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63998] [PATCH] Support commas, exclamation marks correctly in AreaReference

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63998

PJ Fanning <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from PJ Fanning <[hidden email]> ---
Patch applied with https://svn.apache.org/repos/asf/poi/trunk@1872567 - thanks

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]