[Bug 63047] New: Make POILogger subclassable

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 63047] New: Make POILogger subclassable

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63047

            Bug ID: 63047
           Summary: Make POILogger subclassable
           Product: POI
           Version: 4.0.x-dev
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POI Overall
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

POILogger/POILogFactory has a mechanism to allow users override the default
logger. One problem is that POILogger needs to be subclassed but the contructor
is not public - so users have to create the subclass in the org.apache.poi.util
package.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63047] Make POILogger subclassable

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63047

Andreas Beeker <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Andreas Beeker <[hidden email]> ---
Sorry to hijack that issue - but just when I wanted to commit the code and open
a ticket before/for it - you've created it already ...

I think the cleaner way is to use an interface instead of abstract class.

Anything else should be the same.

Applied via r1850040

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 63047] Make POILogger subclassable

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=63047

--- Comment #2 from PJ Fanning <[hidden email]> ---
Strictly speaking the latest revision is a breaking API change. Users who may
have created their own subclasses of POILogger will find that code will not
compile with this change.

All that said, I think the intent is that the next release is 4.1.0 (as opposed
to 4.0.2) - so it should be more acceptable to break APIs, particularly ones
that are unlikely to affect many users.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]