[Bug 61671] New: XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 61671] New: XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

            Bug ID: 61671
           Summary: XSLFSlide does not contain getHidden and setHidden
                    like HSLFSlide does
           Product: POI
           Version: 3.17-FINAL
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSLF
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Actually HSLFSlide contains two methods; getHidden and setHidden; however
XSLFSlide doesn't. It would be nice to have them, we will avoid reading the
full XML Object of the slide.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

Javen O'Neal <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

--- Comment #1 from Ghazi Triki <[hidden email]> ---
I just found this : slide.getXmlObject().getShow()

Is it the correct way?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

Nick Burch <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #2 from Nick Burch <[hidden email]> ---
Any chance you could create a simple PPTX slideshow in PowerPoint, one slide
shown and one hidden, and either upload it here or check the XML inside to
identify the hidden flag? We can then quite quickly add the missing matching
getter / setter methods

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

Ghazi Triki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #3 from Ghazi Triki <[hidden email]> ---
Using this method works

slide.getXmlObject().getShow()

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain getHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

Javen O'Neal <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |---
             Status|RESOLVED                    |REOPENED

--- Comment #4 from Javen O'Neal <[hidden email]> ---
Let's leave this one open until getHidden is part of the XSLF like API. We
don't want users to rely on the underlying xmlbean implementation.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain isHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

Andreas Beeker <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|XSLFSlide does not contain  |XSLFSlide does not contain
                   |getHidden and setHidden     |isHidden and setHidden like
                   |like HSLFSlide does         |HSLFSlide does

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain isHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

--- Comment #5 from Andreas Beeker <[hidden email]> ---
Applied with r1814122

I've changed getHidden() to isHidden() to go along the beans naming convention.
Do we need a deprecated getHidden() for scratchpad? ... I suppose, no

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain isHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

Andreas Beeker <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61671] XSLFSlide does not contain isHidden and setHidden like HSLFSlide does

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61671

--- Comment #6 from Javen O'Neal <[hidden email]> ---
(In reply to Andreas Beeker from comment #5)
> Applied with r1814122
> Do we need a deprecated getHidden() for scratchpad?
No, but it's a pretty small alias to add to our API. If it means greater
adoption of 4.0.0, it'd be helpful to keep it for a release.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]