[Bug 61609] New: TestAttachments on quick-winmail.dat will fail on attachment quick.html due to EOL

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 61609] New: TestAttachments on quick-winmail.dat will fail on attachment quick.html due to EOL

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61609

            Bug ID: 61609
           Summary: TestAttachments on quick-winmail.dat will fail on
                    attachment quick.html due to EOL
           Product: POI
           Version: 3.17-FINAL
          Hardware: PC
            Status: NEW
          Severity: minor
          Priority: P2
         Component: HMEF
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

When building on windows, the quick.html will have different line endings after
checkout from GIT.

The test will then fail because of difference between actual length of
quick.html test file and expected length of quick.html attachment in
quick-winmail.dat file.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61609] TestAttachments on quick-winmail.dat will fail on attachment quick.html due to EOL

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61609

Nick Burch <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 OS|                            |All

--- Comment #1 from Nick Burch <[hidden email]> ---
The master copy of our source control is current SVN -
https://svn.apache.org/repos/asf/poi/trunk/ . I believe we have appropriate
line endings set on the file, but I'm not sure.

Could you try with a svn checkout, and let us know if it's a general Windows
issue, or just a problem with the SVN to Git sync?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61609] TestAttachments on quick-winmail.dat will fail on attachment quick.html due to EOL

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61609

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from [hidden email] ---
I checked with the svn checkout. In svn, the file is correctly set with a
property to leave the EOL "as-is".

So, this seems to be a problem of the git bridge on github.

Maybe a hint on the build-with-git part of the website would be helpful, that
this test might fail because of the checkout issue.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61609] TestAttachments on quick-winmail.dat will fail on attachment quick.html due to EOL

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61609

Dominik Stadler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #3 from Dominik Stadler <[hidden email]> ---
Let's keep it open to check if adding a .gitattribute file can solve this.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61609] TestAttachments on quick-winmail.dat will fail on attachment quick.html due to EOL

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61609

--- Comment #4 from Nick Burch <[hidden email]> ---
Based on https://help.github.com/articles/dealing-with-line-endings/ and
https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows
it doesn't look like Git supports it on a file-by-file basis the same way SVN
does. However, assuming we've been consistent everywhere, it looks like a
.gitattributes file may let us get something close

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]