[Bug 61469] New: [PATCH] Support Array Formulas and Matrix Functions

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 61469] New: [PATCH] Support Array Formulas and Matrix Functions

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61469

            Bug ID: 61469
           Summary: [PATCH] Support Array Formulas and Matrix Functions
           Product: POI
           Version: 3.17-dev
          Hardware: PC
            Status: NEW
          Keywords: PatchAvailable
          Severity: enhancement
          Priority: P2
         Component: SS Common
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 35267
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35267&action=edit
Array Formula and Matrix Function Patch

Hi all,

Array formulas and matrix functions are currently not supported in any version
of POI.

In order to store evaluated Excel arrays, I implemented CacheAreaEval which is
based off of MockAreaEval which holds values for each of the cells in the array
range.

I have also added MatrixFunction which allows for the evaluation of transpose,
mdeterm, minverse, and mmult. This file does depend on commons math3.

The other modifications allow for the evaluation of arrays within the formula
evaluation stack.

Please let me know if there are any changes that need to take place or any
other information is necessary.

I apologize for the size of the patch; I have just recently received approval
from Lawrence Livermore National Laboratory to release the code that was worked
on all summer.

Best Regards,
Robert Hulbert

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61469

--- Comment #1 from Robert D Hulbert <[hidden email]> ---
Created attachment 35268
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35268&action=edit
Numeric Array Formulas and Matrix Function Test Cases

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

Greg Woolsey
This looks incredibly promising.  Worth considering for a re-opened 3.17,
or a short-cycle 3.18?  I know we get requests for array formula support on
a regular basis, and maybe it's my childhood rocket scientist hero-worship
talking, but the facility name attached gives me an initial level of hope
in the completeness and stability of the patch code.

On Tue, Aug 29, 2017 at 8:59 AM <[hidden email]> wrote:

> https://bz.apache.org/bugzilla/show_bug.cgi?id=61469
>
> --- Comment #1 from Robert D Hulbert <[hidden email]> ---
> Created attachment 35268
>   --> https://bz.apache.org/bugzilla/attachment.cgi?id=35268&action=edit
> Numeric Array Formulas and Matrix Function Test Cases
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

[Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61469

PJ Fanning <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #2 from PJ Fanning <[hidden email]> ---
Thanks Robert. I have a preference for viewing the patches in github - and it
allows for easier reviewing. If you have time, would you be able to fork
https://github.com/apache/poi, apply your patch and then create a Pull Request?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61469

--- Comment #3 from PJ Fanning <[hidden email]> ---
From
http://apache-poi.1045710.n5.nabble.com/VOTE-Apache-POI-3-17-release-RC2-td5728603.html,
it seems we are best off leaving this merge until 3.17 is released. Latest code
is in https://github.com/apache/poi/pull/69

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61469

Dominik Stadler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #4 from Dominik Stadler <[hidden email]> ---
This seems to be applied via r1808297, is there anything still missing?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=61469

PJ Fanning <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEEDINFO                    |RESOLVED

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]