[Bug 60887] New: Surface XSSF header/footer attributes

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 60887] New: Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

            Bug ID: 60887
           Summary: Surface XSSF header/footer attributes
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: XSSF
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

The different First Page, and different Even/Odd header/footer attributes of
XSSF spreadsheets are set automatically when the appropriate methods are
called. These attributes cannot be turned off, and there is no way to set the
alignWithMargins and scaleWithDoc attributes.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

Dominik Stadler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

--- Comment #1 from Mark Murphy <[hidden email]> ---
In working through this feature, I have noticed that creating an
XSSFEvenHeader, or an XSSFFirstHeader sets the differentOddEven or
differentFirst attributes respectively. And, setting the text for a header to
an empty string removes that header, but does not attempt to remove the
differentOddEven or differentFirst attributes. I am thinking that setting the
text on an XSSFEvenHeader to the null string should remove the differentOddEven
attribute if the XSSFEvenFooter is not set, and similarly setting text on the
XSSFEvenFooter should remove the differentOddEven attribute if necessary. Same
thing for differentFirst with respect to XSSFFirstHeader and XSSFFirstFooter.
Any objections?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

--- Comment #2 from Greg Woolsey <[hidden email]> ---
Sounds appropriate to me.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Bug 60887] Surface XSSF header/footer attributes

Mark Murphy
In writing unit tests for bug 60887, I have found an issue that I believe
will be confusing to users. I put setters and getters in XSSFHeaderFooter
for the global header/footer attributes. The reason I put it there is that
these attributes are indeed global for the sheet, they are not specific to
First, or Even/Odd headers and footers. Unfortunately this class is
Abstract, and needs to be that way due to the way XSSFHeader,
XSSFFirstHeader, etc. work. So the confusion I can foresee is that If a
user has different First and EvenOdd Headers and Footers, Settiong these
attributes in one will set that attribute in all the rest. It is not
intuitively obvious that if you create an XSSFOddHeader, and an
XSSFEvenHeader that they refer to the same XSSFHeaderFooter object. It then
follows that it wouldn't be obvious by looking at the interface that
changing AlignWithMargins in one will make the same change in all the rest,
but it does. I am not real sure how to deal with this. As it stands, the
classes require an intimate knowledge of the underlying structures in order
to use them effectively, and that is just not right for a user facing
interface.

On Tue, Mar 21, 2017 at 4:16 PM, <[hidden email]> wrote:

> https://bz.apache.org/bugzilla/show_bug.cgi?id=60887
>
> --- Comment #2 from Greg Woolsey <[hidden email]> ---
> Sounds appropriate to me.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

Mark Murphy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Mark Murphy <[hidden email]> ---
Added r1814950

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

--- Comment #4 from Javen O'Neal <[hidden email]> ---
Make sure to document any surprising behavior in the javadoc. It sounds like
some of this functionality would be better implemented in a different class to
make the global behavior less surprising. But I am not familiar enough with
printing, headers, or footers to suggest something better.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

--- Comment #5 from Mark Murphy <[hidden email]> ---
(In reply to Javen O'Neal from comment #4)
> Make sure to document any surprising behavior in the javadoc. It sounds like
> some of this functionality would be better implemented in a different class
> to make the global behavior less surprising. But I am not familiar enough
> with printing, headers, or footers to suggest something better.

I will try to improve the documentation. I Created the
XSSFHeaderFooterProperties class to handle global behavior of these properties.
I can add some examples and a section in the Quick Guide as well. Is there
somewhere else that you experienced unexpected behavior?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60887] Surface XSSF header/footer attributes

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60887

--- Comment #6 from Javen O'Neal <[hidden email]> ---
(In reply to Mark Murphy from comment #5)
> Is there somewhere else that you experienced unexpected behavior?

I haven't used these features or even read the existing javadocs, so no.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]