[Bug 60847] New: CTPlotArea OOXML type needs a cleaner interface

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 60847] New: CTPlotArea OOXML type needs a cleaner interface

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60847

            Bug ID: 60847
           Summary: CTPlotArea OOXML type needs a cleaner interface
           Product: POI
           Version: 3.16-dev
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: XSSF
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

It has separate methods to get lists of all the different chart types it could
possibly contain.  These have many overlapping/common properties.  It is really
annoying to have to write code that explicitly names each list and calls the
proper getXYZChartList() method, then call the same getTitle() method on each
one, typed explicitly.

There should be a common interface defining the common properties, perhaps even
a hierarchy of interfaces, and chart/plot wrapper/handler class, at least for
XSSF, if not common with HSSF, that can return a List of all the charts as
implementations of the common interface(s) defining all the common
methods/properties.

Callers could still get at the underlying explicit types, but in many instances
wouldn't care, and this would remove the need for a lot of boilerplate in
consumer code.

(I'm looking in particular at Vaadin Spreadsheet Charts, and the gyrations they
had to go through to get chart definitions out of POI).

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60847] CTPlotArea OOXML type needs a cleaner interface

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60847

--- Comment #1 from Nick Burch <[hidden email]> ---
The CT classes are auto-generated from the official OOXML schemas. They
therefore can't really be changed (and only properly changed with a time
machine and a seat on the specification committee...)

We generally shouldn't be exposing any CT classes through to end users, these
should normally be wrapped up in friendly POI classes. If there's some missing,
we should add that class, deprecate the raw CT class access, and possibly do
some magic in our classes with xml processing to keep things common (if needed)

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60847] CTPlotArea OOXML type needs a cleaner interface

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60847

--- Comment #2 from Greg Woolsey <[hidden email]> ---
Yes, I know about the generated classes.  I'm proposing I add the missing
"nice" access for them

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60847] CTPlotArea OOXML type needs a cleaner interface

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60847

Alain Fagot Bearez <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Alain Fagot Bearez <[hidden email]> ---
I understand there are still many chart types that are not yet implemented
under the XDDF component in 4.0.0. Many features have been badly and
incompletely tested, when tested at all.

Anyhow I would appreciate some feedback about the @Beta versions already
available and the rough edges that are still present for your experimented use
cases.

Of special interest would be your "missing nice access for them"...

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60847] CTPlotArea OOXML type needs a cleaner interface

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60847

--- Comment #4 from Alain Fagot Bearez <[hidden email]> ---
I would suggest to close this issue as the effort to build some common code to
access charts from XSLF, XSSF and XWPF is now available as XDDF with its own
new set of related bugs.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60847] CTPlotArea OOXML type needs a cleaner interface

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60847

Dominik Stadler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEEDINFO                    |RESOLVED

--- Comment #5 from Dominik Stadler <[hidden email]> ---
Then let's do that and create separate issues for things that are reported as
remaining issues/bugs/...

Thanks for creating the XDDF base so we can provide charts in the different
types of documents.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]