[Bug 60805] New: Remove calls to System.out.print and System.out.println

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 60805] New: Remove calls to System.out.print and System.out.println

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805

            Bug ID: 60805
           Summary: Remove calls to System.out.print and
                    System.out.println
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: POI Overall
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

System.out.print and System.out.println could potentially be added to forbidden
apis if we can exclude dev classes.

grep -r -l --exclude-dir=.svn System.out.println src/java/ src/ooxml/java
src/scratchpad/src/
lists 62 files, most of which are dev classes, but includes some classes that
shouldn't be using System.out.println, such as:
src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60805] Remove calls to System.out.print and System.out.println

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805

Javen O'Neal <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |60787


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=60787
[Bug 60787] CellUtil.class with print strings
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60805] Remove calls to System.out.print and System.out.println

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805

--- Comment #1 from Dominik Stadler <[hidden email]> ---
There is a bundled signature for this:

            <bundledsignatures name="jdk-system-out"/>


However disabling forbidden-apis in all the examples and devtools via
annotation is a bit tedious and excludes all api-checks in those
classes/methods.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60805] Remove calls to System.out.print and System.out.println

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805

Javen O'Neal <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Javen O'Neal <[hidden email]> ---
*** Bug 61536 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60805] Remove calls to System.out.print and System.out.println

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805

--- Comment #3 from Tim Allison <[hidden email]> ---
Doh.  Thank you, Javen...

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 60805] Remove calls to System.out.print and System.out.println

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805

--- Comment #4 from Tim Allison <[hidden email]> ---
r1808903 focused on println in tests.

* redirected stdout for x.main(args) calls.

* deleted a few printlns that were prob useful during development.

* commented out a few printlns that I felt someone might want to turn back on
during development

* converted some to POILogger.log()

* left the printlns in MemoryUsage...not sure what to do with those?!

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]