[Bug 60072] New: Sheet shiftRows doesn't trigger charts position updating

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

            Bug ID: 60072
           Summary: Sheet shiftRows doesn't trigger charts position
                    updating
           Product: POI
           Version: 3.13-FINAL
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
          Assignee: [hidden email]
          Reporter: [hidden email]

Created attachment 34187
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34187&action=edit
Proposed patch

Hi all,
it seems that adding rows on a sheet (using Sheet.shiftRows) does not trigger
any update in charts anchors.
Our proposal is to shift any chart anchor referring a cell above the start row
of the shifted area.
I've attached a patch that includes a new method in XSSFSheet, called from
within the shiftRows method.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

--- Comment #1 from Javen O'Neal <[hidden email]> ---
Thanks for the patch! I'll review it and apply it once 3.15 is released and the
trunk is unfrozen.

Does your patch also update chart data series address ranges? See bug 59306. It
would be nice to have these two fixed at the same time.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

--- Comment #2 from Lapo Cioni <[hidden email]> ---
(In reply to Javen O'Neal from comment #1)
> Thanks for the patch! I'll review it and apply it once 3.15 is released and
> the trunk is unfrozen.
>
> Does your patch also update chart data series address ranges? See bug 59306.
> It would be nice to have these two fixed at the same time.

Unfortunately no.
I've only made some failed attempts to solve the issue related to bug 59306.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

Javen O'Neal <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Javen O'Neal <[hidden email]> ---
Could you move the drawing (chart, picture, object, etc) shifting into the
XSSFRowShifter or RowShifter class?

Would you be willing to write a unit test for this class to prevent regressions
on this feature in future releases? There is a class called
TestXSSFSheetShiftRows or BaseTestSheetShiftRows that would be a good place for
this test. This also proves to others that the behavior works as described.

Thanks!

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

--- Comment #4 from Javen O'Neal <[hidden email]> ---
You can use test-data/spreadsheet/WithChart.xlsx and WithDrawing.xlsx for unit
tests or make your own test spreadsheet (or even better, write a unit test
starting with a new XSSFWorkbook(), add the chart and/or drawing to the
workbook, shift the rows, and verify that the chart and drawing were shifted
the correct number of rows.

https://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

Dominik Stadler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |59306


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=59306
[Bug 59306] Shifting rows does not shift chart data series references
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60072

--- Comment #5 from Dominik Stadler <[hidden email]> ---
Bug #59306 sounds similar or at least closely related.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]